Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fall back to importing dynamic dependencies relative to SvelteKit package #12532

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dummdidumm
Copy link
Member

Simplifies code a bit around usage locations in our own code, and solves some issues people may have with their setups closes #11578


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

…t package

Simplifies code a bit around usage locations in our own code, and solves some issues people may have with their setups
closes #11578
Copy link

changeset-bot bot commented Aug 1, 2024

🦋 Changeset detected

Latest commit: 2609235

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

@sunrabbit123 sunrabbit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good PR.
I'm a user who wants this PR to work and yarn pnp to work.

However, I'm just sad that there hasn't been an update on this recently.

try {
// @ts-expect-error the types are wrong
const resolved = imr.resolve(dependency, pathToFileURL(process.cwd() + '/dummy.js'));
return import(resolved);
return await import(resolved);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way

How about focusing logic on the try syntax?

Suggested change
return await import(resolved);
return await import(resolved).catch(() => import(dependency));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import-meta-resolve dependency breaks Yarn 4 Plug'n'Play/Zero-installs
3 participants