-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fall back to importing dynamic dependencies relative to SvelteKit package #12532
base: main
Are you sure you want to change the base?
Conversation
…t package Simplifies code a bit around usage locations in our own code, and solves some issues people may have with their setups closes #11578
🦋 Changeset detectedLatest commit: 2609235 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good PR.
I'm a user who wants this PR to work and yarn pnp to work.
However, I'm just sad that there hasn't been an update on this recently.
try { | ||
// @ts-expect-error the types are wrong | ||
const resolved = imr.resolve(dependency, pathToFileURL(process.cwd() + '/dummy.js')); | ||
return import(resolved); | ||
return await import(resolved); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way
How about focusing logic on the try syntax?
return await import(resolved); | |
return await import(resolved).catch(() => import(dependency)); |
Simplifies code a bit around usage locations in our own code, and solves some issues people may have with their setups closes #11578
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits