-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add svelte/restrict-mustache-expressions
rule
#840
Draft
AlbertMarashi
wants to merge
12
commits into
sveltejs:main
Choose a base branch
from
AlbertMarashi:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e1c168d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
AlbertMarashi
changed the title
Add
Feat: add Aug 9, 2024
restrict-mustache-expressions
rulerestrict-mustache-expressions
rule
AlbertMarashi
changed the title
Feat: add
feat: add Aug 9, 2024
restrict-mustache-expressions
rulerestrict-mustache-expressions
rule
AlbertMarashi
changed the title
feat: add
feat: add Aug 9, 2024
restrict-mustache-expressions
rulesvelte/restrict-mustache-expressions
rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being able to use non-stringifiable objects in string contexts is a major footgun and surface area for bugs. This new rule creates lint errors for situation such as:
where the
href
is serialised into"/foo/[object Object]"
which is almost never wanted behavior, and these types of bugs can easily be introduced through refactoringRelated: #747