-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: switch to estree
compatible ast tooling
#380
Conversation
🦋 Changeset detectedLatest commit: c850286 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
updated PR description to be more accurate. |
We are getting close... 🎉 Tests are finally green. Only thing left is to write some code to properly detect |
estree
compatible ast tooling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it out and the output looks great!
Closes #44
Closes #118
Relates #100
This basically duplicates #100 at this point. See #100 for up and downsides of this approach.
I was initially intending to get rid of a lot more dependencies (like the dependencies for handling html) and use
svelte-ast-print
instead, but this was opening too many issues at the same time. That's why I opted to "only" switch toacorn
andesrap
here, the rest can be done later.Relevant PR's / issues
TSModuleDeclaration
esrap#44TSImportType
esrap#47@sveltejs/acorn-typescript
esrap#51Benefits
svelte
ecosystemrolldown
#371)recast
esrap
Downsides
TSEstree
as no good public alternative exists, that matchesacorn
s output. We do have@typescript-eslint/types
but that was just the one with the smallest pain points. Still exploring other options.