Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python engine adapters #19

Merged
merged 19 commits into from
Jan 26, 2024
Merged

Python engine adapters #19

merged 19 commits into from
Jan 26, 2024

Conversation

maxwellflitton
Copy link
Contributor

Here I am separating the dependencies out so if a user does just wants to use sklearn then they do not need to have torch and vice versa. I have also isolated the Rust code from the Python code with an adapter pattern so we can now perform unit tests on the processes of training and storing ML files from sklearn and torch and converting them to ONNX. There is still some way to go to get the rust part into unit tests that can be called from Python but for now the rust code itself has unit tests.

@maxwellflitton maxwellflitton merged commit 196a8fd into main Jan 26, 2024
1 check passed
@maxwellflitton maxwellflitton deleted the python-engine-adapters branch February 6, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant