Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid sharing schemes with library users #696

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

sammygutierrez
Copy link
Contributor

What kind of change does this PR introduce?

This is a small change to the project that moves the schemes from the .swiftpm directory to the .xcworkspace. This allows for library users to not see the schemes from Supabase in their own Xcode project.

See here for related blog post:
https://www.jessesquires.com/blog/2025/03/10/swiftpm-schemes-in-xcode/

Other PR example:
sideeffect-io/AsyncExtensions#29

@sammygutierrez sammygutierrez requested a review from grdsdev as a code owner March 27, 2025 02:06
@sammygutierrez sammygutierrez changed the title fix: Avoid sharing schemes with library users fix: avoid sharing schemes with library users Mar 27, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 14097288570

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.875%

Totals Coverage Status
Change from base Build 14038223950: 0.0%
Covered Lines: 5090
Relevant Lines: 6798

💛 - Coveralls

@grdsdev
Copy link
Collaborator

grdsdev commented Mar 27, 2025

Hi @sammygutierrez,

on my tests using your branch, it still shows the schemes for the Supabase products, how can I test this correctly?

@sammygutierrez
Copy link
Contributor Author

Hey @grdsdev. I tested this by creating two new Xcode projects.

The first points to supabase/supabase-swift:

Screenshot 2025-03-27 at 10 17 29 AM

The second points to my fork:

Screenshot 2025-03-27 at 10 17 45 AM

@grdsdev grdsdev merged commit 3caa69f into supabase:main Mar 31, 2025
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants