chore(tests): add auto types gen and override for testing #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avallete
commented
Mar 29, 2025
| "db:clean": "cd test/db && docker compose down --volumes", | ||
| "db:run": "cd test/db && docker compose up --detach && wait-for-localhost 3000" | ||
| "db:run": "cd test/db && docker compose up --detach && wait-for-localhost 3000", | ||
| "db:generate-test-types": "cd test/db && docker compose up --detach && wait-for-localhost 8080 && curl --location 'http://0.0.0.0:8080/generators/typescript?included_schemas=public,personal&detect_one_to_one_relationships=true' > ../types.generated.ts && sed -i 's/export type Json = .*/export type Json = unknown;/' ../types.generated.ts" |
There was a problem hiding this comment.
note
Here we replace the Json type definition by unkown as it allow MergeDeep to work better to override the column type with a custom definition.
Long term, we will deprecate our custom type in favor of unknown for all Json types including for the select-query-parser. This might be a breaking change in the types system for some users.
Related: supabase/postgres-meta#750
Comment on lines
+7
to
+8
| // TODO: should change this type in favor of unknown instead of the current one | ||
| import type { Json } from '../../src/select-query-parser/types' |
There was a problem hiding this comment.
note
Since select-query-parser has it's own static Json type for json field selectors, we must use this one for type equality comparator.
soedirgo
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR improve the testing flow to make it more e2e by:
postgres-metaversionThis will allow us to more easily go from a "sql definition" to an "type inference test".