fix: catch invalid url early #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avallete
commented
Apr 11, 2025
Comment on lines
+31
to
+46
| const encryptedHeader = request.headers['x-connection-encrypted']?.toString() | ||
| if (encryptedHeader) { | ||
| try { | ||
| request.headers.pg = CryptoJS.AES.decrypt(encryptedHeader, CRYPTO_KEY) | ||
| .toString(CryptoJS.enc.Utf8) | ||
| .trim() | ||
| } catch (e: any) { | ||
| request.log.warn({ | ||
| message: 'failed to parse encrypted connstring', | ||
| error: e.toString(), | ||
| }) | ||
| throw new Error('failed to process upstream connection details') | ||
| } | ||
| } else { | ||
| request.headers.pg = PG_CONNECTION | ||
| } |
There was a problem hiding this comment.
note
To identify why and how this happen, would it be okay to console.error the x-connection-encrypted ?
There was a problem hiding this comment.
I think no, safer not to log any potentially sensitive information
Pull Request Test Coverage Report for Build 14401988114Details
💛 - Coveralls |
soedirgo
approved these changes
Apr 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Related: PGMETA-53