Skip to content

fix: downgrade runners #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/publish.reusable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ jobs:
runs-on: ubuntu-latest
permissions:
contents: write
# ? what's this?! required for executing the node script?
id-token: write
steps:
- uses: actions/checkout@v4
Expand Down
16 changes: 9 additions & 7 deletions .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,20 +102,20 @@ jobs:
version: latest
- name: Run Lints
run: |
cargo sqlx prepare --check --workspace
cargo clippy
cargo run -p rules_check
biome lint
cargo sqlx prepare --check --workspace

test:
name: Test
runs-on: ${{ matrix.os }}
strategy:
matrix:
include:
# reactive once we upgrade to the latest version of pg_query that is windows-compatible
- os: windows-latest
- os: ubuntu-latest
# use the same images we use for compiling
- os: windows-2022
- os: ubuntu-22.04
steps:
- name: Checkout PR branch
uses: actions/checkout@v4
Expand All @@ -138,8 +138,10 @@ jobs:
run: cargo test --workspace

test-js-bindings:
name: Test JS Bindings
runs-on: ubuntu-latest
name:
Test JS Bindings
# use the same image we use for compiling
runs-on: ubuntu-22.04
services:
postgres:
image: postgres:latest
Expand Down Expand Up @@ -173,7 +175,7 @@ jobs:

codegen:
name: Check Codegen
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
services:
postgres:
image: postgres:latest
Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,12 @@ jobs:
strategy:
matrix:
config:
- { os: ubuntu-latest, target: x86_64-unknown-linux-gnu }
- { os: ubuntu-latest, target: aarch64-unknown-linux-gnu }
- { os: macos-latest, target: x86_64-apple-darwin }
- { os: macos-latest, target: aarch64-apple-darwin }
- { os: windows-latest, target: x86_64-pc-windows-msvc }
- { os: windows-latest, target: aarch64-pc-windows-msvc }
- { os: ubuntu-22.04, target: x86_64-unknown-linux-gnu }
- { os: ubuntu-22.04, target: aarch64-unknown-linux-gnu }
- { os: macos-14, target: x86_64-apple-darwin }
- { os: macos-14, target: aarch64-apple-darwin }
- { os: windows-2022, target: x86_64-pc-windows-msvc }
- { os: windows-2022, target: aarch64-pc-windows-msvc }

runs-on: ${{ matrix.config.os }}

Expand Down Expand Up @@ -87,12 +87,12 @@ jobs:

# windows is a special snowflake too, it saves binaries as .exe
- name: 👦 Name the Binary
if: matrix.config.os == 'windows-latest'
if: matrix.config.os == 'windows-2022'
run: |
mkdir dist
cp target/${{ matrix.config.target }}/release/postgrestools.exe ./dist/postgrestools_${{ matrix.config.target }}
- name: 👦 Name the Binary
if: matrix.config.os != 'windows-latest'
if: matrix.config.os != 'windows-2022'
run: |
mkdir dist
cp target/${{ matrix.config.target }}/release/postgrestools ./dist/postgrestools_${{ matrix.config.target }}
Expand Down