Multistatement Support #63
Open
+433
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunng87
reviewed
Mar 28, 2025
|
@iPeluwa Thank you for the patch! The features added into this library look good to me. There are some format and lint issues. |
|
@iPeluwa you can run cargo clippy and cargo fmt locally to fix those lint and format issues |
sunng87
approved these changes
Mar 31, 2025
…ster UDF for compatibility
sunng87
reviewed
Apr 2, 2025
| } | ||
| } | ||
| } | ||
| *sc_guard = new_context; |
There was a problem hiding this comment.
We already got this config mutable, why we need to recreate the whole session_context here?
| // Build a ListArray containing "public" | ||
| let mut list_builder = ListBuilder::new(StringBuilder::new()); | ||
| for _ in 0..num_rows { | ||
| list_builder.values().append_value("public"); |
There was a problem hiding this comment.
Can we avoid hardcode public here? Is it possible to read schemas from SessionContext?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.