Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue no. #3785 , there were alot of error in console, had resolved it #4512

Closed
wants to merge 5 commits into from

Conversation

nitin14gupta
Copy link

No description provided.

Copy link

✅ All Jest tests passed! This PR is ready to merge.

Copy link

❌ Some Jest tests failed. Please check the logs and fix the issues before merging.

Failed Tests:

synthutils.test.js

@Ubayed-Bin-Sufian
Copy link
Contributor

@nitin14gupta Please write a summary of errors you fixed. It would be best if you provide screenshots before and after fixing. Also fix the issue related to test. That way maintainers can easily understand what you are trying to achieve.

@omsuneri
Copy link
Member

omsuneri commented Mar 12, 2025

@nitin14gupta your changes are failing a test file so you need to look into that and refactor the changes such that every test must pass and if your changes are making change in the functionality of the root function you need to implement a proper test case for that or refactor the previous written test in the test module for the root file

@omsuneri
Copy link
Member

omsuneri commented Mar 12, 2025

@nitin14gupta also try to provide proper description with demo video or screenshot with your changes if possible it is not a good way to raise an empty description PR
also i m seeing some unwanted merge commits in your PR try to make a new branch with the upstream master and then make all the changes to that branch and raise a PR

@omsuneri
Copy link
Member

Tests:       74 failed, 871 passed, 945 total
Snapshots:   0 total
Time:        5.107 s
Ran all test suites

summary of the failed tests they are huge you need to look into your changes more thanks !!

@Ubayed-Bin-Sufian
Copy link
Contributor

Ubayed-Bin-Sufian commented Mar 19, 2025

@sum2it Kindly close this PR. Too many failed tests.

@sum2it sum2it closed this Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants