Port to Python3, Gtk3 and GLib #5
Conversation
| @@ -1,8 +1,8 @@ | |||
| [Activity] | |||
| name = Frotz | |||
| activity_version = 3 | |||
| bundle_id = vu.lux.olpc.Frotz | |||
| exec = sugar-activity frotz.FrotzActivity | |||
| bundle_id = org.sugarlabs.Frotz | |||
There was a problem hiding this comment.
Is there any particular reason why you changed the bundle id?
There was a problem hiding this comment.
It was giving bundle_id not found error when I tested with python2. But after making changes the error has gone. The activity was not starting before with python2. You can try this one on python2 by changing. Thanks.
There was a problem hiding this comment.
Reasons not to change the bundle_id include;
- when an upgrade of an activity occurs on a system, Journal objects from the old version can continue to be used on the new version; otherwise those Journal objects cannot be opened,
- when an activity is shared between a system using the old bundle_id and another system using the new bundle_id, the sharing will work; otherwise the shared instance will not be displayed in the Neighbourhood View,
- when an upgrade happens while Sugar is running, Sugar will represent only one activity by this name on the menu; otherwise Sugar may represent both the old and new activities on the menu at once if there is a copy of the activity in
~/Activitiesas well as/usr/share/sugar/activities, - locating source code repositories is easy because we can search for the name; otherwise it becomes harder.
I don't think a bundle_id not found error is a correct reason to change the bundle_id. Next time that happens, try to diagnose why it happened rather than jumping to conclusions about the cause. 😁
| @@ -187,28 +188,28 @@ def _paste_cb(self, button): | |||
| self._vte.paste_clipboard() | |||
|
|
|||
| def __key_press_cb(self, window, event): | |||
| if event.state & gtk.gdk.CONTROL_MASK and event.state & gtk.gdk.SHIFT_MASK: | |||
| if event.state & Gtk.gdk.CONTROL_MASK and event.state & Gtk.gdk.SHIFT_MASK: | |||
There was a problem hiding this comment.
This looks like an incomplete port, look for the correct method and make the necessary changes.
If you're not sure what the correct methods are you can check here
There was a problem hiding this comment.
Thanks I will take a look at these ones.
|
|
||
| if gtk.gdk.keyval_name(event.keyval) == "C": | ||
| if Gtk.gdk.keyval_name(event.keyval) == "C": |
| if self._vte.get_has_selection(): | ||
| self._vte.copy_clipboard() | ||
| return True | ||
| elif gtk.gdk.keyval_name(event.keyval) == "V": | ||
| elif Gtk.gdk.keyval_name(event.keyval) == "V": |
| self.set_colors(Gtk.gdk.color_parse (fg_color), | ||
| Gtk.gdk.color_parse (bg_color), |
| vte = cdll.LoadLibrary("lib/%s/libvte.so.9" % vte_path) | ||
| sys.path.append("lib/%s" % vte_path) | ||
| vte = cdll.LoadLibrary("/usr/lib/"+vte_path+"-linux-gnu/libvte-2.91.so.0") | ||
| sys.path.append("/usr/lib/"+vte_path+"-linux-gnu" ) |
There was a problem hiding this comment.
Is there any reason why you added this to the PATH?
There was a problem hiding this comment.
The activity was giving error before given in #4 in python2. The error is gone after changing . You can try this one also. by running on sugar-live-build. Thanks
There was a problem hiding this comment.
The activity was written to work with early versions of Fedora that did not have up to date VTE package. Newer VTE was in the lib directory, for each architecture supported. It also happened in the Lemonade activity. This method was acceptable at the time but was not compliant with the license of VTE, and we no longer need to do it because VTE is sufficiently recent on any system that has Python 3 GTK support. So as you port to GTK 3, you should have assessed if the embedded copy of VTE was needed, and (as it is not) removed it and the code that refers to it.
There was a problem hiding this comment.
And of course remove the lib directory.
There was a problem hiding this comment.
Thanks I didn't know that. I thought the error was just related to not loading the required lib. So I just made necessary changes for working. I will take care about it further.
|
A good rule of thumb is to make sure the activity starts before you start making any changes to it, some changes you made above should be in a separate PR because they help fix the activity before a port to python3, also do test your changes before making a PR. I normally use the |
|
The activity with python 2 was not starting before as It was giving that bundle_id not found error and import vte error (#4 ). I have made that changes but stuck at #6 which was not because of python 3 port. |
Our guide to porting asks that you fix the activity properly on Python 2 before you try porting it to Python 3. We want working code for our users to use; porting to Python 3 is a minor step in that goal. |
I have done with porting . Solved the issue #3 . Kindly review