-
Notifications
You must be signed in to change notification settings - Fork 5
Update Compute cloud deployment docs #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8010e9c
docs: rearrange sidebar and rename page for clarity
LauraLangdon a6648a0
docs: create other deployments section, rearrange cloud deploy section
LauraLangdon 4665b3e
Add local deployment docs (#158)
hola-soy-milk 951c896
fix: standardize capitalization in sidebar
LauraLangdon c945f04
docs: add AWS yaml instructions, create tabs
LauraLangdon 0983e36
fix: delete duplicate minikube page
LauraLangdon 2d1155e
Update website/docs/compute/deployment/other-deployments/minikube.md
LauraLangdon 842f4a8
Merge branch 'main' into laura/166-update-compute-deployment-docs
LauraLangdon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should specify that they need to be added to the yaml file, and also show them in the example. I also wonder if we want to keep this bit about the Kubernetes secret. Maybe we have it link to the other tab?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do specify the different yaml files in the next paragraph down:
Do you mean show the file name in the yaml codeblock? I considered that but decided against it since there are two candidates for the file name depending on whether a deployment is on Kubernetes or local.
I'll add a link to the GCS tab!