refactor: use native types and f-string #2459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jack Cherng <[email protected]>
Signed-off-by: Jack Cherng <[email protected]>
jfcherng
force-pushed
the
feat/future-annotations-more
branch
from
1d67b68
to
f55722c
Compare
Signed-off-by: Jack Cherng <[email protected]>
deathaxe
reviewed
Apr 21, 2024
Signed-off-by: Jack Cherng <[email protected]>
deathaxe
reviewed
Apr 21, 2024
deathaxe
reviewed
Apr 21, 2024
Co-authored-by: deathaxe <[email protected]>
Signed-off-by: Jack Cherng <[email protected]>
|
Okay, now there are only line length issues left. |
jfcherng
force-pushed
the
feat/future-annotations-more
branch
from
391562b
to
3402cce
Compare
Signed-off-by: Jack Cherng <[email protected]>
Signed-off-by: Jack Cherng <[email protected]>
|
please ignore the failing CI, the |
predragnikolic
approved these changes
Apr 23, 2024
|
Thanks for the changes I'll merge this tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
from __future__ import annotations, in type annotations we can convertType=====>typeList=====>listTuple=====>tupleDict=====>dictSet=====>setOptional=====>NoneUnion=====>|Py38 new feature(s):
str.format=====> f-stringNot Done in this PR
By the way, we can upgrade
flake8to v7. We previously stayed at v5 because it won't complaint about unused imports, which is used in# type: .... Or, let's goruffas linter/formatter (this is the setup for all my Python projects now 😄 ).