Skip to content

Commit

Permalink
Remove logging.basicConfig() (#2478)
Browse files Browse the repository at this point in the history
* remove logging.basicConfig()

Avoid polluting other packages

closes #2477

* Revert "remove logging.basicConfig()"

This reverts commit 60e1768.

* add comments
  • Loading branch information
predragnikolic authored May 29, 2024
1 parent ae0b220 commit 8d8f5c7
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion third_party/websocket_server/websocket_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@
from socketserver import ThreadingMixIn, TCPServer, StreamRequestHandler

logger = logging.getLogger(__name__)
logging.basicConfig()
# This line installed a root logger, which results in duplicate log entries.
# For more details, see: https://github.com/sublimelsp/LSP/issues/2477
# logging.basicConfig()

'''
+-+-+-+-+-------+-+-------------+-------------------------------+
Expand Down

0 comments on commit 8d8f5c7

Please sign in to comment.