Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAJOR] Fixed support for passing params and options to retrieve methods #1438

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

prathmesh-stripe
Copy link
Contributor

Changelog

  • Singleton retrieve method now requires params to be passed as the first argument. Existing calls to singleton retrieve method with only opts argument will have to be updated to account for the addition of params argument.
params = { expand: ["available"] }
opts = { stripe_account: "acct_123" }

# ❌ No longer works
Stripe::Balance.retrieve(opts)

# ✅ Correct way to call retrieve method
Stripe::Balance.retrieve(params, opts)

@prathmesh-stripe prathmesh-stripe self-assigned this Jul 19, 2024
@prathmesh-stripe prathmesh-stripe changed the title Fixed support for passing params and options to retrieve methods [MAJOR] Fixed support for passing params and options to retrieve methods Jul 19, 2024
Copy link
Contributor

@helenye-stripe helenye-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the merge-base of this be our next-major branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants