Fix logic for when editing is available for update #4676
Merged
+411
−626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wooj-stripe
commented
Mar 17, 2025
| $0.isCoBrandedCard && cbcEligible | ||
| }) | ||
| default: | ||
| return configuration.paymentMethodRemove || viewModels.contains(where: { | ||
| return configuration.paymentMethodRemove || configuration.paymentMethodUpdate || configuration.paymentMethodSyncDefault || viewModels.contains(where: { |
There was a problem hiding this comment.
Looks like we forgot to add paymentMethodSyncDefault here, so adding it in addition to paymentMethodUpdate
There was a problem hiding this comment.
CustomerSheet is actually a special case— paymentMethodSyncDefault is not a factor in whether a pm can be edited in CustomerSheet because we don't show a default checkbox. For CustomerSheet, we set it as default when a payment method is selected and confirmed.
There was a problem hiding this comment.
Ah! Right!!! Oops. Will change that back! Thanks for catching.
wooj-stripe
changed the title
wooj-stripe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allows users who have integrated with CustomerSessions to update cards if they have paymentmethodRemove || paymentmethodDefault set to disabled.
Motivation
Currently updating cards is only available if you enable paymentMethodDefault or paymentmethodRemove.
Testing
updated existing tests and manually tested
Changelog