Fail & log payment attempt for a deferred intent with a next action #4026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s into joyceqin-MOBILESDK-1792
| @@ -194,6 +194,7 @@ import Foundation | |||
| case paymentSheetFormShown = "mc_form_shown" | |||
| case paymentSheetFormInteracted = "mc_form_interacted" | |||
| case paymentSheetCardNumberCompleted = "mc_card_number_completed" | |||
| case paymentSheetIntentPaymentMethodIdMismatch = "mc_intent_payment_method_id_mismatch" | |||
There was a problem hiding this comment.
Let's rename this to mc_deferred_intent_payment_method_id_mismatch
| @@ -53,6 +54,8 @@ struct PaymentSheetDeferredValidator { | |||
| return | |||
| } | |||
| guard intentPaymentMethod.stripeId == paymentMethod.stripeId else { | |||
| let errorAnalytic = ErrorAnalytic(event: .paymentSheetIntentPaymentMethodIdMismatch, error: PaymentSheetError.unknown(debugDescription: "Payment method ids don't match")) | |||
There was a problem hiding this comment.
Let's use the same error message in debugDescription as we do in the message below in the error we throw.
porter-stripe
approved these changes
Sep 23, 2024
StripePaymentSheet- public init(mode: StripePaymentSheet.PaymentSheet.IntentConfiguration.Mode, paymentMethodTypes: [Swift.String]? = nil, onBehalfOf: Swift.String? = nil, paymentMethodConfigurationId: Swift.String? = nil, confirmHandler: @escaping StripePaymentSheet.PaymentSheet.IntentConfiguration.ConfirmHandler, requireCVCRecollection: Swift.Bool = false)
+ public init(mode: StripePaymentSheet.PaymentSheet.IntentConfiguration.Mode, paymentMethodTypes: [Swift.String]? = nil, onBehalfOf: Swift.String? = nil, paymentMethodConfigurationId: Swift.String? = nil, confirmHandler: @escaping StripePaymentSheet.PaymentSheet.IntentConfiguration.ConfirmHandler)
- public var requireCVCRecollection: Swift.BoolIf you are adding a new public API consider the following:
If you are modifying or removing a public API:
If you confirm these APIs need to be added/updated and have undergone necessary review, add the label ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added an STPAnalyticsEvent paymentSheetIntentPaymentMethodIdMismatch and analytics log to deferred validator and analytics test
Motivation
https://jira.corp.stripe.com/browse/RUN_MOBILESDK-3540
Testing
Asserted that the log fired after deferred validation failure matched the paymentSheetIntentPaymentMethodIdMismatch event
Changelog