When you tap a saved PM, Apple Pay, or Link, PaymentSheet no longer s… #3438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ets it as the default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ets it as the default. They are only set as the default after you successfully confirm.
TODO: Set default for saved PMs, saved Link, Apple Pay?
Motivation
https://jira.corp.stripe.com/browse/MOBILESDK-1855
Testing
We didn't have tests for the removed behavior.
There is a test for the remaining behavior where new PMs are set after successful confirms.
TODO: Add tests for Link, Apple Pay, saved PMs?
Changelog