Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes the scanned name and expiry date of a card publicly visible #3355

Closed
wants to merge 3 commits into from

Conversation

via-guy
Copy link

@via-guy via-guy commented Mar 1, 2024

Summary

Remove @_spi for ScannedCard properties.
Fixes #2484 and #2875

Motivation

In order to autofill our card entry form we need the scanned details, but for some reason they're blocked from being publicly visible.

Testing

It wasn't... I just unblocked some basic properties.

Changelog

[Changed] ScannedCard to allow access for expiryMonth, expiryYear and name.

@via-guy via-guy requested review from a team as code owners March 1, 2024 10:21
@CLAassistant
Copy link

CLAassistant commented Mar 1, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@san-scard
Copy link

san-scard commented Apr 2, 2024

Is this getting updated soon? Would love to get all available data from the scanned card, but the spi properties don't allow it.

@via-guy
Copy link
Author

via-guy commented Apr 3, 2024

@kgaidis-stripe can you please have a look at this? It would really help out a lot of people.

@via-guy
Copy link
Author

via-guy commented Apr 23, 2024

@kgaidis-stripe I know this isn't a critical issue so no rush, but would love to push this tiny PR forward.

@sgrant-stripe sgrant-stripe enabled auto-merge (squash) April 25, 2024 19:13
@sgrant-stripe
Copy link
Contributor

see #3539

auto-merge was automatically disabled April 26, 2024 16:38

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Credit card scanner should scan expiration date and not only "pan"
4 participants