-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Connect SDK] UI for Connect SDK Example App #9276
Conversation
Risky Change This is considered a risky change because it adjusts the sample app build.gradle, please review carefully. By adding the label |
d8ab852
to
0b70efc
Compare
5a99909
to
5d10f7f
Compare
Diffuse output:
APK
|
601e6a3
to
c3eb44d
Compare
private val menuItems = listOf( | ||
MenuItem( | ||
title = "Account Onboarding", | ||
subtitle = "Show a localized onboarding form that validates data", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make these string resources?
cornerRadius = EmbeddedComponentManager.Appearance.CornerRadius() | ||
@Composable | ||
private fun BetaBadge() { | ||
val borderColor = Color(0xffa7e7fc) // none |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also make these resources?
c3eb44d
to
57baafe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree about moving some things to res, looks good on my end! 👍
The base branch was changed.
57baafe
to
b024b59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Summary
This adds the UI for the Connect SDK example app. It's mirrored off of the other example apps in this repo (ex. PaymentSheetExample and FinancialConnectionsExample).
The app has UI for both components in the Connect SDK: AccountOnboarding and Payouts. Both are currently Beta and more can be added easily in the UI as the Connect SDK evolves.
Motivation
This is meant to:
Testing
Screenshots