Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tolu/link/release #10183

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Tolu/link/release #10183

wants to merge 4 commits into from

Conversation

toluo-stripe
Copy link
Contributor

Summary

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

# Conflicts:
#	paymentsheet/src/main/java/com/stripe/android/link/LinkActivityViewModel.kt
Copy link
Contributor

Risky Change

This is considered a risky change because it adjusts the sample app build.gradle, please review carefully.
We've seen issues in the past which resulted in failed builds for merchants. Please make sure the build.gradle change is intended.

By adding the label accept-risky-change to this PR, I acknowledge that I'm changing an example app and have verified that the SDK remains in a shippable state.

Copy link
Contributor

github-actions bot commented Feb 14, 2025

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │          uncompressed          
          ├───────────┬───────────┬──────────┼──────────┬──────────┬──────────
 APK      │ old       │ new       │ diff     │ old      │ new      │ diff     
──────────┼───────────┼───────────┼──────────┼──────────┼──────────┼──────────
      dex │     4 MiB │     4 MiB │   +559 B │  8.8 MiB │  8.8 MiB │   +808 B 
     arsc │   2.3 MiB │   2.3 MiB │      0 B │  2.3 MiB │  2.3 MiB │      0 B 
 manifest │   5.1 KiB │   5.1 KiB │     -1 B │ 25.7 KiB │ 25.7 KiB │      0 B 
      res │ 910.9 KiB │ 910.9 KiB │      0 B │  1.4 MiB │  1.4 MiB │      0 B 
   native │   2.6 MiB │   2.6 MiB │      0 B │    6 MiB │    6 MiB │      0 B 
    asset │   1.6 MiB │   1.6 MiB │ +1.4 KiB │  1.6 MiB │  1.6 MiB │ +1.4 KiB 
    other │   1.4 MiB │   1.4 MiB │    -10 B │  1.6 MiB │  1.6 MiB │      0 B 
──────────┼───────────┼───────────┼──────────┼──────────┼──────────┼──────────
    total │  12.7 MiB │  12.7 MiB │ +1.9 KiB │ 21.7 MiB │ 21.7 MiB │ +2.2 KiB 

 DEX     │ old   │ new   │ diff           
─────────┼───────┼───────┼────────────────
   files │     1 │     1 │  0             
 strings │ 41279 │ 41281 │ +2 (+8 -6)     
   types │ 14291 │ 14291 │  0 (+2 -2)     
 classes │ 11942 │ 11942 │  0 (+2 -2)     
 methods │ 60624 │ 60622 │ -2 (+712 -714) 
  fields │ 40847 │ 40842 │ -5 (+489 -494) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  243 │  243 │  0   
 entries │ 6249 │ 6249 │  0
APK
     compressed      │     uncompressed     │                                
──────────┬──────────┼───────────┬──────────┤                                
 size     │ diff     │ size      │ diff     │ path                           
──────────┼──────────┼───────────┼──────────┼────────────────────────────────
  7.8 KiB │ +1.4 KiB │   7.6 KiB │ +1.4 KiB │ ∆ assets/dexopt/baseline.prof  
    4 MiB │   +559 B │   8.8 MiB │   +808 B │ ∆ classes.dex                  
 53.7 KiB │     -6 B │   119 KiB │      0 B │ ∆ META-INF/CERT.SF             
 50.4 KiB │     -4 B │ 118.9 KiB │      0 B │ ∆ META-INF/MANIFEST.MF         
  1,004 B │     +3 B │     872 B │     +3 B │ ∆ assets/dexopt/baseline.profm 
  5.1 KiB │     -1 B │  25.7 KiB │      0 B │ ∆ AndroidManifest.xml          
──────────┼──────────┼───────────┼──────────┼────────────────────────────────
  4.1 MiB │ +1.9 KiB │     9 MiB │ +2.2 KiB │ (total)
MANIFEST
              │ old                                     │ new                                     
──────────────┼─────────────────────────────────────────┼─────────────────────────────────────────
 package      │ com.stripe.android.paymentsheet.example │ com.stripe.android.paymentsheet.example 
 version code │ 11                                      │ 14                                      
 version name │ 21.4.2                                  │ 21.4.2                                  

@@ -3,3 +3,3 @@
     android:compileSdkVersionCodename="14"
-    android:versionCode="11"
+    android:versionCode="14"
     android:versionName="21.4.2"
DEX
STRINGS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   41279 │ 41281 │ +2 (+8 -6) 
  
  + LL0/C1;
  + Lm6/k;
  + VILLLLLLLLLLLLLLLLLLLLL
  + VLLJZ
  + VLLLLLLLLLLLLLLLLLLLL
  + attest
  + link_consumer_incentive
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"b98ac3b","r8-mode":"full","version":"8.7.14"}
  
  - EditCard
  - LI6/H;
  - LV7/o;
  - VILLLLLLLLLLLLLLLLLLLL
  - WALLET_MENU_EDIT_CARD_TAG
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"de6fb80","r8-mode":"full","version":"8.7.14"}
  

TYPES:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   14291 │ 14291 │ 0 (+2 -2) 
  
  + LL0/C1;
  + Lm6/k;
  
  - LI6/H;
  - LV7/o;
  

METHODS:

   old   │ new   │ diff           
  ───────┼───────┼────────────────
   60624 │ 60622 │ -2 (+712 -714) 
  
  + A5.I0 <init>(V, m, c, h, h, h)
  + A5.I0 <init>(V, h, h, m, h, h)
  + A5.N <init>(m, e, m, h)
  + A5.b a(Context, i) → k
  + B6.x <init>(a, U0)
  + C.D0 M(b, MenuItem) → boolean
  + C.D0 Q(b, l) → boolean
  + C.D0 u(b)
  + C.D0 v(f) → boolean
  + C.I0 S(View, O0) → O0
  + C5.F <init>(h, N, m, h, g, h, h, c, m, d, v0)
  + C5.d <init>(a, a, a, a)
  + C5.g <init>(m, Y0, E, d)
  + Da.b r(CharSequence, int, int, w) → boolean
  + E0.I e() → e1
  + E0.e A(String) → String
  + E0.e B() → Object
  + E0.e G(String) → e1
  + E0.e H(int, byte[])
  + E0.e z() → int
  + E0.f u(JSONObject) → h
  + E0.z <init>(e1)
  + F.T B(k0, e, i) → Object
  + G1.y S(View, O0) → O0
  + G5.H <init>(B, Y0, u, a, d)
  + G7.h <init>(int, String, String, g, String, String, Boolean, Boolean, Boolean, String, String, List, String, Boolean, String, H, H, H, H, List, b, H)
  + G7.h <init>(String, String, g, String, String, Boolean, Boolean, Boolean, String, String, List, String, Boolean, H, H, H, H, List, b, H)
  + H.I S(View, O0) → O0
  + H5.c <init>(e, Y0, s, d)
  + H6.h <init>(h, U0, W, d)
  + H6.i <init>(o, U0, p, W, d)
  + Ha.e i0(m, long, e1) → int
  + I0.L L(Object, Object) → boolean
  + I0.d0 L(Object, Object) → boolean
  + I2.b <init>(m, b, e, m, h)
  + I6.A <init>(G, w, d)
  + I6.A j(Object, Object) → Object
  + I6.A m(Object, d) → d
  + I6.B <init>(G, w, d)
  + I6.C <init>(G, w, d)
  + I6.D <init>(G, c)
  + I6.E <init>(G, c)
  + I6.F <init>(G, c)
  + I6.G <init>(A, b, r, W0, d, c, c, c)
  + I6.G g(G, String, c) → Object
  + I6.G i(G, Throwable, String)
  + I6.G j(w, c) → Object
  + I6.G k(w, String, c) → Object
  + I6.G l(w, c) → Object
  + I6.h <init>(b)
  + I6.h c() → c
  + I6.i <clinit>()
  + I6.j <init>(b, String, boolean)
  + I6.j a() → boolean
  + I6.j b() → String
  + I6.j c() → c
  + I6.k <init>(c, a, c, c, c)
  + I6.k <init>(a, b, c, c, c)
  + I6.k k(Object) → Object
  + I6.l <init>(t, boolean, c, c, a, c, c, c, c, a, int)
  + I6.l <init>(List, o, E, H, boolean, a, c, c, x, p, int)
  + I6.l <init>(boolean, String, Integer, c, String, Integer, c, String, Integer, c, int)
  + I6.l j(Object, Object) → Object
  + I6.m <init>(t, boolean, c, c)
  + I6.m k(Object) → Object
  + I6.n <init>(t, boolean, Y0, n0, c, c, a, a, a, a, c, c, c, c, a, int, int, int)
  + I6.n <init>(String, Integer, String, Integer, String, Integer, boolean, e, e, c, c, c, a, c, a, int, int)
  + I6.n j(Object, Object) → Object
  + I6.o <init>(LayoutWeightElement, t, boolean, Y0, n0, c, c, a, c, c, c, c, a, int, int)
  + I6.p <init>(c, w, int)
  + I6.p a() → Object
  + I6.q <init>(List, boolean, t, c, c)
  + I6.q l(Object, Object, Object, Object) → Object
  + I6.r <init>(a, c, w, int)
  + I6.r a() → Object
  + I6.s <init>(t, h, d)
  + I6.s j(Object, Object) → Object
  + I6.s m(Object, d) → d
  + I6.s o(Object) → Object
  + I6.t <init>(List, w, boolean, c, boolean, boolean, String, c, a, a, c)
  + I6.t a(t, List, w, boolean, String, c, a, a, c, int) → t
  + I6.t b() → k0
  + I6.t equals(Object) → boolean
  + I6.t hashCode() → int
  + I6.t toString() → String
  + I6.u <init>(G, d)
  + I6.u j(Object, Object) → Object
  + I6.u m(Object, d) → d
  + I6.u o(Object) → Object
  + I6.v <init>(G, d)
  + I6.w <init>(G, d)
  + I6.x <init>(G, d)
  + I6.y <init>(G, d)
  + I6.z <init>(G, c)
  + I7.f t(boolean)
  + I7.g0 <init>(e)
  + I7.g0 t(boolean)
  + I9.b C(t, c, c, p, int)
  + I9.b D(LayoutWeightElement, t, boolean, Y0, n0, c, c, a, c, c, c, c, a, p, int, int)
  + I9.b E(t, boolean, c, c, a, c, c, c, c, a, p, int)
  + I9.b G(t, boolean, Y0, n0, c, c, a, a, a, a, c, c, c, c, a, p, int, int)
  + I9.b
...✂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant