Redesign restart events #152
Conversation
Signed-off-by: Katherine Stanley <[email protected]>
101-redesign-restart-events.md
Outdated
| This will be a change for users, however since the events being emitted aren't versioned there is no clear way to indicate this change. | ||
| However, we can introduce this change at the same time as the v1 API. | ||
| When the v1 API lands users are likely to be reviewing the changelog more thoroughly than for other releases, increasing the likelihood that they will not be caught out by the change. |
There was a problem hiding this comment.
I'm fine with this. But you can also consider doing it in 0.46 which has the CHANGELOG full of similar changes.
There was a problem hiding this comment.
I've updated it to say we should aim for 0.46 release, but if we miss that use the release where the v1 API lands
There was a problem hiding this comment.
Are we also updating or adding log messages?
In #10958 we mention the possibility to remove events with the benefit of simplified maintenance. I'm ok to keep them, but maybe we should add the removal as rejected alternative with some motivation.
Signed-off-by: Katherine Stanley <[email protected]>
@ppatierno I think we could, however I think that is outside the scope of this proposal and related issue.
@fvaleri the proposal includes updating the restart reason to include the pod name, however there are no other log message changes included. The issue was around the events being hard to find, not the operator logs being unclear. |
Signed-off-by: Katherine Stanley <[email protected]>
Signed-off-by: Katherine Stanley <[email protected]>
ppatierno
requested review from
im-konge,
see-quick,
sknot-rh and
samuel-hawker
|
This proposal has now 4 +1 (binding) votes and 2 +1 (non binding). Waiting one more day for last minute additional feedback, then @katheris I think you can merge it. |
No description provided.