Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add some software-terms words that start with "un" #3446

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

ssbarnea
Copy link
Collaborator

@ssbarnea ssbarnea commented Aug 7, 2024

Add/Fix Dictionary

Dictionary: software-terms

Description

Checklist

  • By submitting this pull-request, you agree to follow our Code of Conduct
  • Verify that the title starts with the correct prefix:
    • fix: - for minor changes like adding words or fixing spelling issues.
    • feat: - for a significant change like adding a whole new set of words to a dictionary.
    • feat!: - for breaking changes, like file format or licensing changes.
    • chore: - for changes that do not impact the content of dictionaries.

Fixes: #3129
Fixes: streetsidesoftware/cspell#5286
Needs: #3617

@ssbarnea ssbarnea marked this pull request as ready for review August 7, 2024 08:38
@ssbarnea
Copy link
Collaborator Author

ssbarnea commented Aug 7, 2024

@Jason3S That things with "4 workflows awaiting approval" does not seem very welcoming,... and I even contributed previously. Maybe a tune in settings would be possible? ;)

@Jason3S
Copy link
Collaborator

Jason3S commented Aug 7, 2024

@Jason3S That things with "4 workflows awaiting approval" does not seem very welcoming,... and I even contributed previously. Maybe a tune in settings would be possible? ;)

I would be happy to add you as a contributor.

The default security settings have gotten stricter over time.

Copy link
Collaborator

@Jason3S Jason3S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ssbarnea,

Thank you for the additions and taking the time to do it.

dictionaries/en_US/src/additional_words.txt Outdated Show resolved Hide resolved
@Jason3S
Copy link
Collaborator

Jason3S commented Aug 7, 2024

@ssbarnea,

It is ok to just add words to the end of the file, it will get sorted automatically.

@Jason3S
Copy link
Collaborator

Jason3S commented Aug 21, 2024

@ssbarnea,

Would you like some help with this PR?

@ssbarnea
Copy link
Collaborator Author

@Jason3S no, is just that I got sidetracked by other activities. I just seen the invite from you a minute ago but it expired.

@Jason3S
Copy link
Collaborator

Jason3S commented Aug 21, 2024

@ssbarnea,

I just seen the invite from you a minute ago but it expired.

I'll send it again.

- add missing software-terms
- lowercase few terms
- correct sorting
- add correction for instantiatable
Fixes: streetsidesoftware#3129 streetsidesoftware#3129
@ssbarnea
Copy link
Collaborator Author

ssbarnea commented Oct 1, 2024

@Jason3S Something unexpected happened when I updated this PR. I seen failing to run because pnpm lock was out of sync with the package.json, and I did not touch those files.

See https://github.com/streetsidesoftware/cspell-dicts/actions/runs/11125090808/job/30912037317

I have experience using reqs and lock files with npm and yarn, but not pnpm but I assume that they would work very similarly. The only case where this would happen is if someone would push a change bypassing the GHA pipelines, which I doubt is the case.

Maybe there is something incorrectly configured on GHA that allowed this to happen, or some caching went nuts?

As the issue reproduced locally, I raised #3617 which should address this issue.

@Jason3S
Copy link
Collaborator

Jason3S commented Oct 1, 2024

@Jason3S Something unexpected happened when I updated this PR. I seen failing to run because pnpm lock was out of sync with the package.json, and I did not touch those files.

See https://github.com/streetsidesoftware/cspell-dicts/actions/runs/11125090808/job/30912037317

I have experience using reqs and lock files with npm and yarn, but not pnpm but I assume that they would work very similarly. The only case where this would happen is if someone would push a change bypassing the GHA pipelines, which I doubt is the case.

Maybe there is something incorrectly configured on GHA that allowed this to happen, or some caching went nuts?

As the issue reproduced locally, I raised #3617 which should address this issue.

Thank you. I hadn't realize the build was broken. The last publish PR had a stale lock file, causing it to fail. #3612 had an updated package.json, but not an updated pnpm-lock.yaml.

@Jason3S
Copy link
Collaborator

Jason3S commented Oct 1, 2024

@ssbarnea,

Thank you for fixing the files.

@Jason3S Jason3S merged commit 1144d9e into streetsidesoftware:main Oct 1, 2024
9 checks passed
@github-actions github-actions bot mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants