Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Snippets #41

Merged
merged 41 commits into from
May 17, 2024
Merged

Code Snippets #41

merged 41 commits into from
May 17, 2024

Conversation

cdedreuille
Copy link
Collaborator

@cdedreuille cdedreuille commented May 13, 2024 •
edited
Loading

This PR improves the Code Snippets to work with the new data structure.

  • Pre is now fully working with the right wrapper.
  • We don't have 3 components anymore. We only have a server and client component.
  • Copy to clipboard is now working for both CodeSnippets and Pre
  • Copy to clipboard is now decoded to make sure you have the cleanest code to copy.
  • Making sure that if the language or package manager is not set, we still show a default value.
  • CodeSnippets story is using the latest tech from 8.1 to mimic our context. Thanks a lot @JReinhold for helping me setting this out. 🙏

@vercel Vercel
Copy link

vercel bot commented May 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 11:02am

@linear Linear
Copy link

linear bot commented May 13, 2024

SB-1207 Docs - Add new CodeSnippets

@storybookjs storybookjs deleted a comment from netlify bot May 17, 2024
kylegach
kylegach approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@kylegach kylegach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! 👏 🙌

@cdedreuille cdedreuille merged commit f267124 into main May 17, 2024
6 checks passed
@cdedreuille cdedreuille deleted the charles/sb-1207-docs-add-new-codesnippets branch May 17, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylegach kylegach kylegach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdedreuille @kylegach