Merge pull request #220 from storybookjs/cache-versions-response

Cache /versions response for 10 min
storybookjs · Aug 12, 2024 · 2a91532 · 2a91532
2 parents 09a1777 + 8357b0c
commit 2a91532
Show file tree

Hide file tree

Showing 4 changed files with 7,747 additions and 4,050 deletions.
diff --git a/apps/addon-catalog/components/search-results.tsx b/apps/addon-catalog/components/search-results.tsx
@@ -22,18 +22,16 @@ export const SearchResults = ({
       {loading ? <div>Loading...</div> : null}
       {!loading && searchResults.length === 0 && <div>No results found</div>}
       {!loading && searchResults.length > 0 && (
-        <>
-          <div className="grid grid-cols-1 gap-6 lg:grid-cols-2 xl:grid-cols-3">
-            {searchResults.map((item) => (
-              <Preview
-                key={item.name}
-                orientation="vertical"
-                element={item}
-                type={item.type === 'Recipe' ? 'recipe' : 'addon'}
-              />
-            ))}
-          </div>
-        </>
+        <div className="grid grid-cols-1 gap-6 lg:grid-cols-2 xl:grid-cols-3">
+          {searchResults.map((item) => (
+            <Preview
+              key={item.name}
+              orientation="vertical"
+              element={item}
+              type={item.type === 'Recipe' ? 'recipe' : 'addon'}
+            />
+          ))}
+        </div>
       )}
     </div>
   );

diff --git a/apps/frontpage/app/versions/route.ts b/apps/frontpage/app/versions/route.ts
@@ -129,6 +129,10 @@ export async function GET(request: NextRequest) {
 
   return new Response(res[0], {
     status: 200,
-    headers: { 'Access-Control-Allow-Origin': '*' },
+    headers: {
+      'Access-Control-Allow-Origin': '*',
+      // Cache for 10 minutes
+      'Cache-Control': 'public s-max-age=36000',
+    },
   });
 }
diff --git a/apps/frontpage/components/home/develop/develop.tsx b/apps/frontpage/components/home/develop/develop.tsx
@@ -1,7 +1,6 @@
 'use client';
 
 import React, { useRef } from 'react';
-import type { MotionValue } from 'framer-motion';
 import { useScroll, useTransform, useSpring, motion } from 'framer-motion';
 import Link from 'next/link';
 import { ChevronSmallRightIcon } from '@storybook/icons';
@@ -22,7 +21,7 @@ export function Develop() {
   const smoothAppearProgress = useSpring(appearProgress, {
     stiffness: 1000,
     damping: 100,
-  }) as MotionValue<number>;
+  });
 
   // Step 1
   const { scrollYProgress: isolationProgress } = useScroll({