Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add Rsbuild Storybook builder to builders page #30693

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

fi3ework
Copy link
Contributor

@fi3ework fi3ework commented Feb 27, 2025

Add Rsbuild Storybook Builder to the builder page, this is the official Storybook integration of Rspack ecosystem. Feel free to come up with any comment or suggestions. 😀

Related PR: storybookjs/web#268.

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

This PR adds the Rspack/Rsbuild builder to Storybook's builders documentation, providing users with information about this bundling option alongside the existing Webpack and Vite builders.

  • Added Rspack/Rsbuild builder to docs/builders/index.mdx as a third bundling option
  • Highlighted Rspack's "blazing fast" performance as a key feature
  • Included link to the official GitHub repository (rspack-contrib/storybook-rsbuild)
  • Maintained consistent documentation format with existing builder options

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

@fi3ework fi3ework changed the title Update ./docs/versions/next.json for v8.7.0-alpha.0 Docs: Add Rsbuild Storybook builder to builders page Feb 27, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

nx-cloud bot commented Feb 27, 2025

View your CI Pipeline Execution ↗ for commit f296f66.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 57s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-27 03:36:54 UTC

@kylegach kylegach self-assigned this Feb 27, 2025
Copy link
Contributor

@kylegach kylegach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @fi3ework! This is a great idea. 👍

@kylegach
Copy link
Contributor

Not sure why CI is failing, but this is a trivial docs-only change that I manually verified is formatted correctly, so I'm going to merge anyway.

@kylegach kylegach added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch ci:docs Run the CI jobs for documentation checks only. labels Feb 27, 2025
@kylegach kylegach merged commit 7f01df3 into storybookjs:next Feb 27, 2025
11 of 16 checks passed
shilman pushed a commit that referenced this pull request Mar 1, 2025
Docs: Add Rsbuild Storybook builder to builders page
(cherry picked from commit 7f01df3)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 1, 2025
@github-actions github-actions bot mentioned this pull request Mar 5, 2025
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs Run the CI jobs for documentation checks only. documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants