Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: Prerelease 8.3.0-alpha.10 #28982

Merged
merged 47 commits into from
Aug 27, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 27, 2024

This is an automated pull request that bumps the version from 8.3.0-alpha.9 to 8.3.0-alpha.10.
Once this pull request is merged, it will trigger a new release of version 8.3.0-alpha.10.
If you're not a core maintainer with permissions to release you can ignore this pull request.

To do

Before merging the PR, there are a few QA steps to go through:

  • Add the "freeze" label to this PR, to ensure it doesn't get automatically forced pushed by new changes.
  • Add the "ci:daily" label to this PR, to trigger the full test suite to run on this PR.

And for each change below:

  1. Ensure the change is appropriate for the version bump. E.g. patch release should only contain patches, not new or de-stabilizing features. If a change is not appropriate, revert the PR.
  2. Ensure the PR is labeled correctly with one of: "BREAKING CHANGE", "feature request", "bug", "maintenance", "dependencies", "documentation", "build", "unknown".
  3. Ensure the PR title is correct, and follows the format "[Area]: [Summary]", e.g. "React: Fix hooks in CSF3 render functions". If it is not correct, change the title in the PR.
    • Areas include: React, Vue, Core, Docs, Controls, etc.
    • First word of summary indicates the type: “Add”, “Fix”, “Upgrade”, etc.
    • The entire title should fit on a line

This is a list of all the PRs merged and commits pushed directly to next, that will be part of this release:

  • 🐛 Bug: Vitest: Fix add command #28975
  • 🔧 Maintenance: Core: De-duplicate babel use in core #28972
  • 🐛 Bug: CLI: Fix dedent import in package managers #28980
  • 🐛 Bug: Addon Vitest: Fix postinstall file types #28978
  • ⚠️ Direct commit: make prettier a normal dependency of core again. restore formatter code e7bea85db9239c383f7c0c0854790235fd2d6eff
  • 📝 Documentation: Docs: Story globals improvements #28856
  • 🏗️ Build: CI: Fix portable-stories-react not being able to link @testing-library/jest-dom #28971

If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.

Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.

When everything above is done:


Generated changelog

8.3.0-alpha.10

kylegach and others added 30 commits August 9, 2024 15:51
- Improve feature flag callouts
- Add API details to migration notes and clarify examples
- Restructure guides to use sub-heading structure instead of snippet tabs
    - Offers ability to explain differences between APIs more thoroughly
    - Also a better experience, because users' tab preference will not apply across snippets
- Clarify example snippets
    - Only demonstate one concept per snippet
- Adjust heading levels
- Add globals API reference section
- Improve snippet filenames
    - Remove redundant `storybook-` prefix
- Prose tweaks
- Explain globals API and feature flag once, at the top
- Reference that callout in consistent manner throughout page
- Wrap entire docs section in "feature flag callout" to better differentiate
- Remove headings for with/without feature flag sections
    - Headings will be removed in SB 9+, so they're not a stable reference
- Polish and details
- Make Viewport match structure and style of Backgrounds
Co-authored-by: jonniebigodes <[email protected]>
* next: (281 commits)
  fix
  add `node:` prefixes
  move nx cache dir up to avoid vite watching it for our main storybook
  Bump version from "8.3.0-alpha.5" to "8.3.0-alpha.6" [skip ci]
  Write changelog for 8.3.0-alpha.6 [skip ci]
  minor fixes
  Yeah... don't look at this
  simplify eslint config further
  more fixes
  cleanup `no-extraneous-dependencies`
  fix style
  change pool options in sandboxes
  revamp sandbox setup to move to a workspace file
  fix typescript issue
  skip vitest integration in nextjs sandbox
  skip sveltekit tests
  fix script
  increase test timeout
  fix parallelism and skip more stories
  fix windows unit tests
  ...
* next: (27 commits)
  apply fix for #28883
  fixes
  apply linting to scripts
  update snapshots
  cleanup
  remove duplicate comment
  more fixes
  jsdoc linting fixes
  misc fixes
  remove invalid syntax
  remove duplicate comment
  remove duplicate comment
  remove duplicate comment
  remove duplicate comment
  remove duplicate comment
  move comment
  move comment
  remove redundant comment
  fix linting of jsdoc comments example blocks
  fix snapshots
  ...
* next: (60 commits)
  Version it
  Make sure local @storybook/cli packages is used in linked mode
  add default options for addon-viewports via parameters
  Fix tests
  Fix default viewports
  Bump version from "8.3.0-alpha.7" to "8.3.0-alpha.8" [skip ci]
  Write changelog for 8.3.0-alpha.8 [skip ci]
  fix lint
  fix lint
  fix lint
  fix types
  Addon Vitest: Improve transformation logic to avoid duplicate tests
  fix lint
  fix lint
  fix formatting
  SvelteKit: Add portable stories vite plugin
  add vite plugin to sveltekit
  increase CI class for vitest integration
  Addon-docs: Remove babel dependency
  Bump version from "8.3.0-alpha.6" to "8.3.0-alpha.7" [skip ci]
  ...
…jest-dom-dep

CI: Fix portable-stories-react not being able to link `@testing-library/jest-dom`
@github-actions github-actions bot added the release For PRs that trigger new releases. Automated label Aug 27, 2024
@storybook-bot storybook-bot force-pushed the version-non-patch-from-8.3.0-alpha.9 branch from aee5944 to 4492f8e Compare August 27, 2024 14:50
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

29 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings


> ! You need to set the feature flag `backgroundsStoryGlobals` to `true` in your `.storybook/main.ts` to use the new format.
The `addon-backgrounds` addon now uses a new format for parameters. The `backgrounds` parameter is now an object with an `options` property that is assigned to an object of background values, where the key is used when setting the global value.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Update backgrounds parameter to use 'options' instead of 'values'


The `addon-viewport` addon now uses a new format for parameters. The `viewport` parameter is now an object with a `viewports` key that contains the viewport values.
The `addon-viewport` addon now uses a new format for parameters. The `viewport` parameter is now an object with an `options` property that is assigned to an object of viewport values, where the key is used when setting the global value.

```diff
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Update viewport parameter to use 'options' instead of 'viewports'

},
};
```

Setting an override value should now be done via a `globals` property on your component/meta or story itself:
Setting an override value should now be done via a `globals` property on your component/meta or story itself. Also note the change from `defaultOrientation: "landscape"` to `isRotated: true`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Use 'globals' instead of 'parameters' for setting viewport

```

```ts filename=".storybook/preview.ts" renderer="common" language="ts"
// Replace your-renderer with the renderer you are using (e.g., react, vue3, angular, etc.)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax: Replace 'your-renderer' with the actual renderer being used (e.g., react, vue3, angular)

@storybook-bot storybook-bot force-pushed the version-non-patch-from-8.3.0-alpha.9 branch from 4492f8e to e2edee5 Compare August 27, 2024 14:59
@storybook-bot storybook-bot force-pushed the version-non-patch-from-8.3.0-alpha.9 branch from e2edee5 to 174bfc4 Compare August 27, 2024 15:39
@shilman shilman added freeze Freeze the Release PR with this label ci:daily Run the CI jobs that normally run in the daily job. labels Aug 27, 2024
Copy link

nx-cloud bot commented Aug 27, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 438ce2c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@shilman shilman removed freeze Freeze the Release PR with this label ci:daily Run the CI jobs that normally run in the daily job. labels Aug 27, 2024
@storybook-bot storybook-bot force-pushed the version-non-patch-from-8.3.0-alpha.9 branch from 174bfc4 to 438ce2c Compare August 27, 2024 16:26
@shilman shilman added freeze Freeze the Release PR with this label ci:daily Run the CI jobs that normally run in the daily job. labels Aug 27, 2024
@shilman shilman merged commit c109493 into next-release Aug 27, 2024
109 checks passed
@shilman shilman deleted the version-non-patch-from-8.3.0-alpha.9 branch August 27, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:daily Run the CI jobs that normally run in the daily job. freeze Freeze the Release PR with this label release For PRs that trigger new releases. Automated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants