refactor: Improve AST-related types readability & fix existing issues #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, I broke build. Working on it |
|
Blocked by: sveltejs/svelte#13135 |
JReinhold
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To summarize, the main objective - fix CI
checkWhat has been done
I've created two types (namespaces),
SvelteAST&ESTreeASTthat are used across entire codebase (imported from#parser/ast).I figured when wrapped into two namespaces is it easier to read and to quickly see from which AST they come from.
This project is unique for using both Svelte AST and ESTree AST, so I hope this clears possible future confusion.
svelteto latest rc version (where AST types fromsvelte/compilerare finally exposed),I could see the existing types issues related to previous PR attempts to fix breaking change in Svelte AST
(references: [Bug]:
autodocsusingsvelte-csfv5does not render individual story within docs #199 fix(parser): Resolveautodocstag issue and extractingrawCode#201). So, I solved them + refactored them a little bit with early returns. There are small logic duplications, but I didn't mind them as they are easier to read and maintain than having very long and complicated if/else statements.What is not included
There are only warnings left with deprecations related to
<svelte:component>and<script context="module">.I'd rather them being solved them in separate PRs.