Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change theme spacing #47

Merged
merged 2 commits into from
Jan 13, 2025
Merged

chore: change theme spacing #47

merged 2 commits into from
Jan 13, 2025

Conversation

marcosh-ramos
Copy link
Collaborator

@marcosh-ramos marcosh-ramos commented Jan 13, 2025

closes #33 #43

What?

In this PR we decreased the spacing size from 5 to 4. Also, we start rounding down the size that is passed to the spacing function, so the spacing cannot be used incorrectly with non-integers.

Why?

How to test? (optional)

  • Open the preview on vercel and check if the spaces still good.

Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 7:07pm

src/theme/light-theme.tsx Outdated Show resolved Hide resolved
@marcosh-ramos marcosh-ramos changed the base branch from upgrade-storybook to main January 13, 2025 19:00
- decreasing the spacing size from 5 to 4
- round down floating point numbers
@marcosh-ramos marcosh-ramos merged commit 48938c5 into main Jan 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New spacing
3 participants