Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revise: allow validate_inputs to accept input content directly #350

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

revise: allow validate_inputs to accept input content directly #350

wants to merge 2 commits into from

Conversation

fahdfady
Copy link

@fahdfady fahdfady commented Mar 11, 2025 •
edited
Loading

…validate_json_file
resolves #347

@fahdfady fahdfady changed the title change parse_inputs to parse_json_path with different logic , rename … Enhancement request: Allow validate_inputs to accept input content directly Mar 11, 2025
@fahdfady fahdfady marked this pull request as ready for review March 12, 2025 13:46
@claymcleod claymcleod changed the title Enhancement request: Allow validate_inputs to accept input content directly revise: allow validate_inputs to accept input content directly Mar 19, 2025
@claymcleod claymcleod requested review from peterhuene, a-frantz and adthrasher and removed request for peterhuene March 19, 2025 15:59
@claymcleod claymcleod added the S-awaiting-review State: awaiting initial or additional review label Mar 19, 2025
@claymcleod
Copy link
Member

Hi @fahdfady, there are some CI issues if you could look at addressing those. Thank you!

@claymcleod claymcleod added S-awaiting-revisions State: awaiting revisions based on code review feedback and removed S-awaiting-review State: awaiting initial or additional review labels Mar 19, 2025
@fahdfady
Copy link
Author

@claymcleod maybe this should be drafted?
from what i understood @peterhuene said it should be hold off. correct me if i'm wrong.

@peterhuene
Copy link
Collaborator

That's correct, we have a PR in-progress on wdl-engine to put support for YAML into Inputs, which we can then utilize in the helper for validating inputs and also update sprocket to support YAML from the configuration file (which at that point will be just updating the command line option help text).

@peterhuene peterhuene added the S-blocked State: blocked on an external change or decision label Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-frantz a-frantz Awaiting requested review from a-frantz

@peterhuene peterhuene Awaiting requested review from peterhuene

@adthrasher adthrasher Awaiting requested review from adthrasher

Assignees

@fahdfady fahdfady

Labels
S-awaiting-revisions State: awaiting revisions based on code review feedback S-blocked State: blocked on an external change or decision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement request: Allow validate_inputs to accept input content directly
3 participants
@fahdfady @claymcleod @peterhuene