-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release as a package and monorepo structure #87
Conversation
@eyalcohen4 is attempting to deploy a commit to the Elegance Team on Vercel. A member of the Team first needs to authorize it. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: @playwright/[email protected], @replayio/[email protected], [email protected] |
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Sorry for the delay! Had a company offsite so couldn't work on it. expecting to have the time to ship it next week. |
@steven-tey This is ready for review! The We can iterate and improve in a new PR on:
I know lot of people need this PR to be done already (including me) so we can first release and then improved. |
@eyalcohen4 @steven-tey Is there some update on that matter? It would be terrific to get to make a package out of this. 🙂 |
ready for review :) |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@eyalcohen4 @steven-tey Many thanks for your effort, this is super cool. I am so much looking forward to it. 🙂 |
@eyalcohen4 @steven-tey @jaril Are there some news in getting novel released as package? If so, it would be terrific to have a small manual that covers things like
Would that be possible? 🙂 |
Would love to get it out as well! @junoriosity |
Deployment failed with the following error:
|
Sneak peek: https://www.npmjs.com/package/novel 👀 Finally got that sweet |
We're ditching the playwright tests for now btw, @jaril will add it back in another PR for the monorepo! 🙏 |
Merging now! Here goes nothing 🙈 |
@steven-tey I have seen quite some activity here. :) Is the package published now or is there still something left to be done? |
@junoriosity it's published: https://www.npmjs.com/package/novel Launching it on Twitter/LinkedIn soon! :) |
Nice! Love this made it in |
Overview
This PR allow for publishing novel as a package.
We have used turborepo to enable it, and moved the repository into a monorepo structure.
In order to re-use the tailwind and ts configuration, we've created 2 packages called
tailwind-config
andts-config
that are shared between thenovel
package and theapp
.The novel package is built using tsup.
New commands
Since we moved to a monorepo structure, dev and build commands should be run in the root folder.
To run the project now, you can run
$ pnpm run dev
in the root folder, and to build it for release you should call$ pnpm run build
in the root folder as well.New Repo Structure
Todo List