Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide inapplicable plugins from bubble-menu #119

Closed

Conversation

firehudson
Copy link

@firehudson firehudson commented Aug 24, 2023

Summary

Hide all inapplicable plugins from the bubble menu for CodeBlock and Code.

This PR is dependent on #117 and will have to be updated once #117 is merged.

Existing Scenario

When CodeBlock is active, other inapplicable plugins (link-selector, bold, italic, other text-decoration plugins...) are visible (and ineffective).

image

Updated Scenario

Only Node Selector is visible, and changing node activates other plugins in the bubble menu.

image

@vercel
Copy link

vercel bot commented Aug 24, 2023

@firehudson is attempting to deploy a commit to the Elegance Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Aug 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
novel ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2023 5:07am

@steven-tey
Copy link
Owner

Appreciate the PR, but ideally we'd want to be able to let the code blocks display those plugin attributes as well – the same way Notion does it! Closing this for now – sorry about that!

@steven-tey steven-tey closed this Aug 26, 2023
@mmailaender
Copy link

mmailaender commented Aug 28, 2023

Appreciate the PR, but ideally we'd want to be able to let the code blocks display those plugin attributes as well – the same way Notion does it! Closing this for now – sorry about that!

Could you please elaborate a bit more of your thoughts? @steven-tey
I understand the idea to have a notion like editor, but especially this behavior feels more like a "not yet solved bug" then a feature. If a user that is not yet used to the behavior of code blocks tries to format a code block and nothing happens it's a bit confusing. (I just had this feedback last week from one of my clients - he tried to add colors 😉)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants