Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/collision detection for selector dropdowns #115

Conversation

prathameshjchavan
Copy link
Contributor

Fixes Collision detection for Selector dropdowns #64

  • Added Radix Popover for Color Selector
  • Added fixed height for color selector and overflow scroll
  • Fixed interactive issue after implementing Radix Popover
fix.mp4

@vercel
Copy link

vercel bot commented Aug 20, 2023

@prathameshjchavan is attempting to deploy a commit to the Elegance Team on Vercel.

A member of the Team first needs to authorize it.

@steven-tey
Copy link
Owner

Incredible! Wanna add this to the NodeSelector as well? 🙏

@vercel
Copy link

vercel bot commented Aug 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
novel ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2023 4:21am

@prathameshjchavan
Copy link
Contributor Author

Incredible! Wanna add this to the NodeSelector as well? 🙏

I think the node selector is already perfect. Please let me know if I missed out something.

node-selector.mp4

@steven-tey
Copy link
Owner

Converting the NodeSelector to Radix Popover would be great because it currently doesn't handle collision detection well 😅

CleanShot 2023-08-25 at 00 07 23@2x

@steven-tey
Copy link
Owner

Added this to NodeSelector – merging now! Thank you!

@steven-tey steven-tey merged commit 06cc16f into steven-tey:main Aug 26, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants