tmp fix for exercise 9 #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimothyGu
requested changes
Sep 14, 2016
| , split = require('split') | ||
| , chalk = require('chalk') | ||
| , tuple = require('tuple-stream') | ||
| , through2 = require('through2') |
There was a problem hiding this comment.
These dependencies are not added to packages.json.
| exercise = comparestdout(exercise) | ||
| exercise.addProcessor(function (mode, callback) { | ||
| let outputStream = through2.obj(function (chunk) { | ||
| const result = chunk[0] === chunk[1] |
There was a problem hiding this comment.
Don't use ES2015 let and const. var would do.
There was a problem hiding this comment.
I changed that, but what's the reason?
There was a problem hiding this comment.
We still support old Node.js I think
TimothyGu
approved these changes
Sep 14, 2016
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
temporary fix for issue #92 (and #81), a legit fix would have to re-implement comparestdout.js, but just to compare first two lines