Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDP-1549] Make Confirm Disbursement atomic #241

Merged
merged 3 commits into from
Feb 21, 2025
Merged

[SDP-1549] Make Confirm Disbursement atomic #241

merged 3 commits into from
Feb 21, 2025
+59 −23

Conversation

marwen-abid
Copy link
Collaborator

New Function Addition:

  • Added postDisbursementWithInstructions function in src/api/postDisbursementWithInstructions.ts to handle disbursements with instructions and file uploads in a single atomic API call.

Matching backend change : stellar/stellar-disbursement-platform-backend#554

@marwen-abid marwen-abid self-assigned this Feb 19, 2025
@stellar-jenkins
Copy link

stellar-disbursement-platform-frontend-preview is available here:
http://sdp-frontend-pr241.previews.kube001.services.stellar-ops.com/

@marwen-abid marwen-abid force-pushed the feat/SDP-1549-make-confirm-disbursement-atomic branch from f45af0b to 5c3fc61 Compare February 19, 2025 16:56
@stellar-jenkins
Copy link

stellar-disbursement-platform-frontend-preview is available here:
http://sdp-frontend-pr241.previews.kube001.services.stellar-ops.com/

marcelosalloum
marcelosalloum approved these changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@marcelosalloum marcelosalloum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Plz, feel free to merge it after addressing the comments below.

@marcelosalloum
Copy link
Collaborator

I forgot to mention: can you plz update the CHANGELOG.md file?

@marwen-abid marwen-abid force-pushed the feat/SDP-1549-make-confirm-disbursement-atomic branch from 5c3fc61 to c9089a7 Compare February 20, 2025 19:25
@stellar-jenkins
Copy link

stellar-disbursement-platform-frontend-preview is available here:
http://sdp-frontend-pr241.previews.kube001.services.stellar-ops.com/

1 similar comment
@stellar-jenkins
Copy link

stellar-disbursement-platform-frontend-preview is available here:
http://sdp-frontend-pr241.previews.kube001.services.stellar-ops.com/

@marwen-abid marwen-abid force-pushed the feat/SDP-1549-make-confirm-disbursement-atomic branch from c82b29b to 8313dd4 Compare February 20, 2025 19:58
@stellar-jenkins
Copy link

stellar-disbursement-platform-frontend-preview is available here:
http://sdp-frontend-pr241.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

stellar-disbursement-platform-frontend-preview is available here:
http://sdp-frontend-pr241.previews.kube001.services.stellar-ops.com/

@marwen-abid marwen-abid merged commit 82a1ca3 into develop Feb 21, 2025
7 checks passed
@marwen-abid marwen-abid deleted the feat/SDP-1549-make-confirm-disbursement-atomic branch February 21, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelosalloum marcelosalloum marcelosalloum approved these changes

@quietbits quietbits Awaiting requested review from quietbits

Assignees

@marwen-abid marwen-abid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marwen-abid @stellar-jenkins @marcelosalloum