Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: connect wallet button updating the screen with correct data #133

Closed
wants to merge 1 commit into from

Conversation

HctZb
Copy link

@HctZb HctZb commented Aug 15, 2023

Problem

The Connect Wallet button don't trigger Freighter to popup the login window, also the UI don't update when you login.

This fix both problems by setting a high level context with the logged account.

Solves #129

@paulbellamy paulbellamy self-assigned this Aug 21, 2023
@paulbellamy
Copy link
Contributor

The context seems like a nice solution, but when I connect and try to mint some of the ABND token, it says that freighter is not connected. Seems like the context and freighter are getting out-of-sync somehow.

cc @piyalbasu

@HctZb
Copy link
Author

HctZb commented Aug 21, 2023

@paulbellamy thanks for the comment.

If you look here, Tyler removed this param signAndSend, that triggers freighter to sign the transaction to complete the operation. Adding this to both mint and pledge solves this.
Should we add this back to the code ?

@paulbellamy
Copy link
Contributor

Oh interesting. Nice catch, thanks!

@tyvdh Was there a reason to remove those? or mistake?

@kalepail
Copy link
Contributor

That was likely done as these params will be changing in a future release of the CLI. Or maybe the current version the CLI has already removed these? cc @chadoh might know better as that was technically his PR

@HctZb HctZb closed this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants