-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#proposal 86 tags and mobile #3934
base: master
Are you sure you want to change the base?
#proposal 86 tags and mobile #3934
Conversation
Implementation of a "Back to top" icon in the bottom right corner on Desktop devices. Currently only on Desktop due to the design / implementation challenge on mobile devices.
Removed the "overflow: hidden" from the .App_content style in Apps.scss so that any overlays do not get cropped when opened. Bug Fix steemit#3931
Implemented the Community Carousel in Communities on Mobile Devices. Users no long need to scroll past lots of pinned posts before seeing community content.
Updated the link structure to improve SEO for community content. Instead of 'hive-xxxxxx' in the URL, this is replaced by the communtiy name (switched to lower case and special characters removed/updated) or if this is invalid, the 1st tag of the user content. This update also includes implementation of updated 'canonical-url' information so that Google prioritises the more SEO friendly URL.
Introduced a check on the 'settings' object (in Community Settings) so that it's not an empty object. If no 'avatar_url' or 'cover_url' is set, the object will now reflect this.
Introduced a getTags request to retrieve Tags information from Hivemind in order to get the /tags page working again. This is currently hard coded to retrieve (the maximum of) 250 tags but should be configured to accept this number as a variable to allow for the future implementation of a Tag Cloud or other functionality. Community tags (i.e. 'hive-xxxxxx) are currently filtered out of the /Tags page but a future update could introduce these as their own section.
Update nodes (steemit#3933)
@ety001 - Could you please deploy this to steemitdev for me? Could you also check Hivemind since the data on steemitdev has not been updated for 21 days (likely caused by this - steemit/hivemind#345) |
Fix for bug steemit#3935 so that the Preview clears the floating Markdown Style Guide.
Hi, it has been deployed and hivemind also was fixed. |
Removed unnecessary comments and console.logs from 2 files.
Removed console.log from PostList.jsx
Hi @ety001 - I've made an update to remove some comments and console logs. It shouldn't affect anything (all tested and working) - could you please deploy it to steemitdev and I'll do a final round of testing. Thank you. |
Hi it has been deployed. |
Implemented the Community Carousel on Mobile devices
Updated the URL structure and corresponding Canonical URL to improve SEO
Implemented 'Back-to-top' on Desktop
Fixed the '/tags' page
Fixed Bug Payout dropdown menu is cut off at the bottom #3931
Fixed Bug UpdateProps of community settings is rejected by Hivemind as invalid #3932