Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add FII_F macro in math/base/napi/ternary #6542

Merged
merged 1 commit into from
Apr 5, 2025

Conversation

Neerajpathak07
Copy link
Contributor

@Neerajpathak07 Neerajpathak07 commented Apr 4, 2025

Resolves None.

Description

What is the purpose of this pull request?

This pull request:

  • adds macro for FII_F in math/base/napi/ternary

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Apr 4, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/napi/ternary $\color{green}155/155$
$\color{green}+100.00\%$
$\color{green}5/5$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}155/155$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review April 4, 2025 13:43
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Apr 4, 2025
@anandkaranubc anandkaranubc changed the title feat: add FIF_F macro in math/base/napi/ternary feat: add FII_F macro in math/base/napi/ternary Apr 4, 2025
@anandkaranubc
Copy link
Contributor

@Neerajpathak07, is there a specific reason you need these macros? I believe they have been usually added on a need basis.

@kgryte
Copy link
Member

kgryte commented Apr 4, 2025

they have been usually added on a need basis.

Agreed. It is probably all right to add single-precision macros which have a double-precision equivalent. At the same time, adding these macros without an immediate use case is low priority.

Regardless, we don't need to discard the proposed changes, so long as they are good. @anandkaranubc would you mind performing an initial review?

@kgryte kgryte added Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. labels Apr 4, 2025
@anandkaranubc anandkaranubc self-requested a review April 4, 2025 23:52
Copy link
Contributor

@anandkaranubc anandkaranubc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good!

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Apr 5, 2025
@kgryte kgryte merged commit 8459c35 into stdlib-js:develop Apr 5, 2025
93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Issue involves or relates to C. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants