feat: add C ndarray interface and refactor implementation for stats/base/dmeanpn
#6510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…base/dmeanpn`
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: passed
- task: lint_package_json
status: na
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: missing_dependencies
- task: lint_c_examples
status: missing_dependencies
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
stdlib-bot
added
Statistics
Coverage Report
The above coverage report was generated for the changes in this PR. |
aayush0325
requested changes
Apr 3, 2025
| @@ -175,6 +166,108 @@ console.log( v ); | |||
|
|
|||
| <!-- /.examples --> | |||
|
|
|||
| <!-- C usage documentation. --> | |||
There was a problem hiding this comment.
incorrect readme structure, see #5138 for example
|
|
||
| ```c | ||
| #include "stdlib/stats/base/dmeanpn.h" | ||
| #include <stdint.h> |
There was a problem hiding this comment.
Suggested change
| #include <stdint.h> |
this header is not being used
| for ( i = 0; i < x.length; i++ ) { | ||
| x[ i ] = ( randu()*20.0 ) - 10.0; | ||
| } | ||
| var x = filledarrayBy( len, 'float64', rand ); |
There was a problem hiding this comment.
just use @stdlib/random/array/uniform here no need to create another function
There was a problem hiding this comment.
same comment for other benchmarks
There was a problem hiding this comment.
remove the stdint.h header from here as it isn't being used
Comment on lines
+55
to
+56
| var ox = stride2offset( N, strideX ); | ||
| return ndarray( N, x, strideX, ox ); |
There was a problem hiding this comment.
Suggested change
| var ox = stride2offset( N, strideX ); | |
| return ndarray( N, x, strideX, ox ); | |
| return ndarray( N, x, strideX, stride2offset( N, strideX ) ); |
There was a problem hiding this comment.
replace all instances of stride with strideX here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
status: passed
status: passed
status: passed
status: na
status: passed
status: passed
status: na
status: na
status: passed
status: passed
status: na
status: na
status: missing_dependencies
status: missing_dependencies
status: na
status: na
status: na
status: passed
status: na
status: passed
Resolves None
Description
This pull request:
stats/base/dmeanpnRelated Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers