Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add constants/float16/fourth-root-eps #6497

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

hrshya
Copy link
Contributor

@hrshya hrshya commented Apr 1, 2025

Resolves none .

Description

What is the purpose of this pull request?

This pull request:

  • adds constants/float16/fourth-root-eps .

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolve no related issue.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Apr 1, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Apr 1, 2025

Coverage Report

Package Statements Branches Functions Lines
constants/float16/fourth-root-eps $\color{green}53/53$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}0/0$
$\color{green}+100.00\%$
$\color{green}53/53$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte
Copy link
Member

kgryte commented Apr 2, 2025

@hrshya How did you calculate the value of this constant to ensure it is correctly rounded for half-precision?

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Discussion Needs further discussion. and removed Needs Review A pull request which needs code review. labels Apr 2, 2025
@hrshya
Copy link
Contributor Author

hrshya commented Apr 3, 2025

@hrshya How did you calculate the value of this constant to ensure it is correctly rounded for half-precision?

@kgryte I went through this wiki ( https://en.wikipedia.org/wiki/Half-precision_floating-point_format ) and calculated the value of fourth root of 1/2^10 because half precision have 10 fraction bit and arrived at this value 0.1767766952966369 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issue or pull request for adding a new feature. Needs Discussion Needs further discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants