[RFC]: refactor and add accessor protocol support to stats/base/mean #5629 #5730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…5629 Refactor the mean function to add support for the accessor protocol. This change ensures that the function can handle array-like objects with custom accessors, improving flexibility and compatibility with various data structures. - Refactor mean function in main.js to delegate to ndarray.js - Update ndarray.js to handle accessor protocol - Add tests for accessor protocol support - Fix JSDoc comments and examples for accuracy Fixes: stdlib-js#5629 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na --- Resolves stdlib-js#5629. > What is the purpose of this pull request? This pull request: - Refactors the mean function to add support for the accessor protocol. This change ensures that the function can handle array-like objects with custom accessors, improving flexibility and compatibility with various data structures. > Does this pull request have any related issues? This pull request: - resolves stdlib-js#5629 > Any questions for reviewers of this pull request? No. > Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes. No. > Please ensure the following tasks are completed before submitting this pull request. - [x] Read, understood, and followed the [contributing guidelines][contributing]. * * * @stdlib-js/reviewers [contributing]: https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md
stdlib-bot
added
Statistics
|
Hello! 👋 I've noticed that your commit doesn't contain the expected YAML metadata blocks. This typically happens when your development environment isn't properly set up with the stdlib git hooks. Here's how to fix this:
If you're still having issues, please check our development guide for more information. Thank you for your contribution! |
Coverage Report
The above coverage report was generated for the changes in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the mean function to add support for the accessor protocol. This change ensures that the function can handle array-like objects with custom accessors, improving flexibility and compatibility with various data structures.
Fixes: #5629
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
type: pre_push_report
description: Results of running various checks prior to pushing changes. report:
type: pre_push_report
description: Results of running various checks prior to pushing changes. report:
type: pre_push_report
description: Results of running various checks prior to pushing changes. report:
type: pre_push_report
description: Results of running various checks prior to pushing changes. report:
type: pre_push_report
description: Results of running various checks prior to pushing changes. report:
Resolves #5629.
Description
This pull request:
stats/base/mean#5629Related Issues
This pull request:
stats/base/mean#5629Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers