Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add constants/float32/min-base10-exponent-subnormal #3100

Merged
merged 3 commits into from
Nov 12, 2024
Merged

feat: add constants/float32/min-base10-exponent-subnormal #3100

merged 3 commits into from
Nov 12, 2024

Conversation

aayush0325
Copy link
Contributor

@aayush0325 aayush0325 commented Nov 11, 2024 •
edited
Loading

Resolves #3094

Description

What is the purpose of this pull request?

This pull request:

  • adds constants/float32/min-base10-exponent-subnormal

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@aayush0325 aayush0325 changed the title feat: add constants/float32/max-base10-exponent-subnormal feat: add constants/float32/min-base10-exponent-subnormal Nov 11, 2024
@aayush0325
Copy link
Contributor Author

ready for review @Planeshifter !

Planeshifter
Planeshifter requested changes Nov 11, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left two comments with requested changes.

...n-base10-exponent-subnormal/include/stdlib/constants/float64/min_base10_exponent_subnormal.h Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/constants/float32/min-base10-exponent-subnormal/package.json Outdated Show resolved Hide resolved
Planeshifter
Planeshifter approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the edits! Looking good now; will merge shortly.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Nov 12, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add `constants/float32/min-base10-exponent-subnormal`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3100
Closes: https://github.com/stdlib-js/stdlib/issues/3094

Reviewed-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit a4ca598 into stdlib-js:develop Nov 12, 2024
16 checks passed
@aayush0325 aayush0325 deleted the min-base10-exponent-subnormal branch November 12, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add constants/float32/min-base10-exponent-subnormal
3 participants
@aayush0325 @stdlib-bot @Planeshifter