feat: add math/base/special/lcmf
#3096
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gunjjoshi I've worked on this package |
Planeshifter
changed the title
math/base/special/lcmf
gunjjoshi
reviewed
Nov 11, 2024
gunjjoshi
reviewed
Nov 11, 2024
gunjjoshi
reviewed
Nov 11, 2024
gunjjoshi
reviewed
Nov 11, 2024
gunjjoshi
added
Needs Changes
Co-authored-by: Gunj Joshi <[email protected]> Signed-off-by: Harsh Mathur <[email protected]>
Co-authored-by: Gunj Joshi <[email protected]> Signed-off-by: Harsh Mathur <[email protected]>
Co-authored-by: Gunj Joshi <[email protected]> Signed-off-by: Harsh Mathur <[email protected]>
|
@gunjjoshi I've done changes as requested by you |
gunjjoshi
reviewed
Nov 12, 2024
gunjjoshi
reviewed
Nov 12, 2024
gunjjoshi
reviewed
Nov 12, 2024
gunjjoshi
reviewed
Nov 12, 2024
gunjjoshi
reviewed
Nov 12, 2024
gunjjoshi
reviewed
Nov 12, 2024
gunjjoshi
reviewed
Nov 12, 2024
gunjjoshi
reviewed
Nov 12, 2024
gunjjoshi
reviewed
Nov 12, 2024
gunjjoshi
reviewed
Nov 12, 2024
lib/node_modules/@stdlib/math/base/special/lcmf/benchmark/c/benchmark.c
Outdated
Show resolved
Hide resolved
gunjjoshi
reviewed
Nov 12, 2024
gunjjoshi
reviewed
Nov 12, 2024
Co-authored-by: Gunj Joshi <[email protected]> Signed-off-by: Harsh Mathur <[email protected]>
…nchmark.c Co-authored-by: Gunj Joshi <[email protected]> Signed-off-by: Harsh Mathur <[email protected]>
Replaced rand_int from rand_double as mentioned across other files Signed-off-by: Harsh Mathur <[email protected]>
Signed-off-by: Harsh Mathur <[email protected]>
Signed-off-by: Harsh Mathur <[email protected]>
Co-authored-by: Gunj Joshi <[email protected]> Signed-off-by: Harsh Mathur <[email protected]>
resolved import errors Signed-off-by: Harsh Mathur <[email protected]>
resolved copy-paste error Signed-off-by: Harsh Mathur <[email protected]>
|
@gunjjoshi Following issues were resolved. |
gunjjoshi
reviewed
Nov 12, 2024
gunjjoshi
reviewed
Nov 12, 2024
gunjjoshi
reviewed
Nov 12, 2024
Co-authored-by: Gunj Joshi <[email protected]> Signed-off-by: Harsh Mathur <[email protected]>
Co-authored-by: Gunj Joshi <[email protected]> Signed-off-by: Harsh Mathur <[email protected]>
replaced space with tab indentation Signed-off-by: Harsh Mathur <[email protected]>
Signed-off-by: Harsh Mathur <[email protected]>
gunjjoshi
reviewed
Nov 12, 2024
Co-authored-by: Gunj Joshi <[email protected]> Signed-off-by: Harsh Mathur <[email protected]>
Co-authored-by: Gunj Joshi <[email protected]> Signed-off-by: Harsh Mathur <[email protected]>
Signed-off-by: Harsh Mathur <[email protected]>
gunjjoshi
reviewed
Nov 12, 2024
| @@ -0,0 +1,77 @@ | |||
| /** | |||
There was a problem hiding this comment.
Same goes for this too, we should follow the JS implementation of math/base/special/lcm here.
| // MAIN // | ||
|
|
||
| /** | ||
| * Computes the least common multiple (LCM) of two floating-point numbers. |
There was a problem hiding this comment.
Here too, the description should match with what we have everywhere else.
Comment on lines
+31
to
+34
| * @private | ||
| * @param {number} a - first floating-point number | ||
| * @param {number} b - second floating-point number | ||
| * @returns {number} least common multiple of `a` and `b` |
There was a problem hiding this comment.
This should be changed as well.
|
@Harsh-Mathur-1503 You can once refer |
Signed-off-by: Harsh Mathur <[email protected]>
Co-authored-by: Gunj Joshi <[email protected]> Signed-off-by: Harsh Mathur <[email protected]>
Co-authored-by: Gunj Joshi <[email protected]> Signed-off-by: Harsh Mathur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolvesa part of #649.
Description
This pull request:
math/base/special/lcmf.Related Issues
This pull request:
Questions
No.
Other
Open to reviews.
Checklist
@stdlib-js/reviewers