Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: blas/ext/base/snansumkbn2 according to current project conventions #3002

Merged
merged 2 commits into from
Oct 12, 2024
Merged

refactor: blas/ext/base/snansumkbn2 according to current project conventions #3002

merged 2 commits into from
Oct 12, 2024

Conversation

gururaj1512
Copy link
Contributor

Resolves #1530.

Description

What is the purpose of this pull request?

This pull request:

  • Refactors blas/ext/base/snansumkbn2 to follow current project conventions

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Oct 12, 2024
@Planeshifter Planeshifter self-requested a review October 12, 2024 17:05
@Planeshifter Planeshifter added the Needs Review A pull request which needs code review. label Oct 12, 2024
@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Oct 12, 2024
Planeshifter
Planeshifter approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gururaj1512 for refactoring the snansumkbn2 package. Your contribution looks great and will be merged shortly.

@stdlib-bot
Copy link
Contributor

PR Commit Message

refactor: `blas/ext/base/snansumkbn2` according to current project conventions

PR-URL: https://github.com/stdlib-js/stdlib/pull/3002
Closes: https://github.com/stdlib-js/stdlib/issues/1530
Ref: https://github.com/stdlib-js/stdlib/issues/1152

Co-authored-by: Gururaj Gurram <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit efbff47 into stdlib-js:develop Oct 12, 2024
17 of 18 checks passed
@Planeshifter Planeshifter mentioned this pull request Oct 12, 2024
Merged
1 task
@gururaj1512 gururaj1512 deleted the refactor-snansumkbn2 branch October 12, 2024 18:44
aayush0325 pushed a commit to aayush0325/stdlib that referenced this pull request Nov 11, 2024
@gururaj1512 @Planeshifter @aayush0325
refactor: blas/ext/base/snansumkbn2 according to current project co…
beb16bf 
…nventions

PR-URL: stdlib-js#3002
Closes: stdlib-js#1530
Ref: stdlib-js#1152

Co-authored-by: Gururaj Gurram <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/snansumkbn2 to follow current project conventions
3 participants
@gururaj1512 @stdlib-bot @Planeshifter