Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ndarray/base/fill #2817

Merged
merged 17 commits into from
Sep 7, 2024
Merged

feat: add ndarray/base/fill #2817

merged 17 commits into from
Sep 7, 2024

Conversation

headlessNode
Copy link
Contributor

Progresses #2656.

Description

What is the purpose of this pull request?

This pull request:

  • Adds implementation of ndarray/base/fill

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@headlessNode headlessNode marked this pull request as draft August 21, 2024 13:56
@headlessNode
Copy link
Contributor Author

@kgryte I think the benchmarks and tests will essentially be similar to ndarray/base/assign?

@kgryte
Copy link
Member

kgryte commented Aug 21, 2024

the benchmarks and tests will essentially be similar to ndarray/base/assign

Yes, I think so.

@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Aug 23, 2024
kgryte
kgryte requested changes Aug 23, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is looking good, @headlessNode. Left a few comments, but this one is close to ready.

@headlessNode headlessNode marked this pull request as ready for review August 23, 2024 19:18
@headlessNode
Copy link
Contributor Author

@kgryte Done. Please review, thanks!

@kgryte kgryte added the Needs Review A pull request which needs code review. label Sep 7, 2024
@headlessNode
Copy link
Contributor Author

@kgryte I realized after adding all the benchmarks that you meant to add benchmarks for 2d only. So its up to you if you want to remove the other benchmarks.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Sep 7, 2024
kgryte
kgryte approved these changes Sep 7, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @headlessNode!

@kgryte kgryte merged commit 6a6bc1d into stdlib-js:develop Sep 7, 2024
11 checks passed
@headlessNode headlessNode deleted the ndarray-base-fill branch September 8, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@headlessNode @kgryte