Implement rlpx peer connections limit #3149
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
why The number of incoming connections were not restricted in the `p2p` handler. Even worse, there was a nimbus option `--max-peers` which was used to set up the minimum(sic) number of peers to keep connected with. Now, the re-organised nimbus options mean: * `--min-peers` -- minimum number of connections to hold * `--max-peers` -- maximum number of all peer connections caveat While the p2p module now rejects new incoming connections when the limit is reached it does allow more connection list entries for outgoing connection when explicitly using the `connectToNode()` function (as in `rpc/common.nim`, `sync/peers.nim` and probably others.) In practice, this lead to at most one more connections on the list.
arnetheduck
reviewed
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
The number of incoming connections were not restricted in the
p2phandler. Even worse, there was a nimbus option
--max-peerswhichwas used to set up the minimum(sic) number of peers to keep
connected with.
Now, the re-organised nimbus options mean:
--min-peers-- minimum number of connections to hold--max-peers-- maximum number of all peer connectionscaveat
While the p2p module now rejects new incoming connections when
the limit is reached it does allow more connection list entries
for outgoing connection when explicitly using the
connectToNode()function (as in
rpc/common.nim,sync/peers.nimand probablyothers.) In practice, this lead to at most one more connections on
the list.