Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom network support in nrpc #3148

Merged
merged 4 commits into from
Mar 18, 2025
Merged

custom network support in nrpc #3148

merged 4 commits into from
Mar 18, 2025

Conversation

advaita-saha
Copy link
Contributor

This is needed while testing and debugging for devnet-6, seems like a nice to have add-on

Verified

This commit was signed with the committer’s verified signature.
advaita-saha Advaita Saha

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@tersec
Copy link
Contributor

tersec commented Mar 17, 2025

The UX on this is, I'm not sure -- it seems odd to have this situation where the --network parameter knows it can't find a built-in one and then one has to use this --custom-network-file (as /path/to/metadata.yaml, distinct from --custom-network, which is as /path/to/genesis.json) parameter.

They're in the same directories for all the EF-supported networks:

So while it's fine to document that these files are different (metadata.yaml vs genesis.json) the actual path is the same and having two different command-line options for basically the same thing is odd.

There's a separate question of, should it be a --custom-network at all or a nimbus-eth2-style implied check in --network, but at least for this PR, it seems ok to at least avoid creation of similar-but-not-identical --custom-network-file.

Verified

This commit was signed with the committer’s verified signature.
advaita-saha Advaita Saha

Verified

This commit was signed with the committer’s verified signature.
advaita-saha Advaita Saha
@tersec tersec merged commit dbf85f1 into master Mar 18, 2025
5 checks passed
@tersec tersec deleted the nrpc-custom-network branch March 18, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants