multi-arch docker builder #3138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once merged, a follow up PR would be to hive, for leveraging the extremely fast build times as per other client standards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes ensure that we dynamically tag our images based on the branch name and a short commit SHA while also addressing the push-by-digest error that occurred with plain tags. The workflow now builds multi-architecture images (
amd64andarm64) and creates a manifest list that includes two variants for each build: one tagged with the branch name (e.g.,master) and one with the branch name concatenated with the short SHA (e.g.,master-abcdef0).