Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

self keyword to const #7417

Closed
wants to merge 1 commit into from
Closed

self keyword to const #7417

wants to merge 1 commit into from

Conversation

piotmag769
Copy link
Collaborator

No description provided.

@piotmag769 piotmag769 requested a review from orizi March 7, 2025 12:46
@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@Draggu Draggu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware and @orizi)

@piotmag769
Copy link
Collaborator Author

@orizi I cannot seem to push a fix for rustfmt for some reason:

remote: error: GH006: Protected branch update failed for refs/heads/self-const.
remote: 
remote: - Required status check "code-review/reviewable" is expected.
remote: 
remote: - Cannot force-push to this branch
To github.com:starkware-libs/cairo.git
 ! [remote rejected]     self-const -> self-const (protected branch hook declined)
error: failed to push some refs to 'github.com:starkware-libs/cairo.git'

@orizi
Copy link
Collaborator

orizi commented Mar 7, 2025

Your work branches should have separating /.
This was caught by the catch all branch protector rules

@piotmag769
Copy link
Collaborator Author

Closing in favour of #7420

@piotmag769 piotmag769 closed this Mar 7, 2025
@orizi orizi deleted the self-const branch March 12, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants