Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tuple-returning special functions #1346

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Add tuple-returning special functions #1346

merged 1 commit into from
Aug 18, 2023

Conversation

WardBrian
Copy link
Member

@WardBrian WardBrian commented Aug 16, 2023

Counterpart to stan-dev/math#2931

Submission Checklist

Release notes

Exposed new functions qr_thin, eigendecompose_sym, eigendecompose, complex_schur_decompose, svd, and csr_extract.

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #1346 (d269060) into master (0e32ba1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1346      +/-   ##
==========================================
+ Coverage   89.27%   89.29%   +0.01%     
==========================================
  Files          65       65              
  Lines       10615    10626      +11     
==========================================
+ Hits         9477     9488      +11     
  Misses       1138     1138              
Files Changed Coverage Δ
src/middle/Stan_math_signatures.ml 98.06% <100.00%> (+0.01%) ⬆️

@WardBrian WardBrian marked this pull request as ready for review August 18, 2023 16:52
Copy link
Contributor

@SteveBronder SteveBronder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WardBrian WardBrian merged commit 69edf41 into master Aug 18, 2023
2 checks passed
@WardBrian WardBrian deleted the feature/tuple-fns branch August 18, 2023 20:20
@WardBrian WardBrian mentioned this pull request Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants